[Merge] ~waveform/livecd-rootfs:pi-tidy-1 into livecd-rootfs:ubuntu/master

Steve Langasek mp+450872 at code.launchpad.net
Wed Sep 13 16:21:17 UTC 2023


On Tue, Sep 12, 2023 at 02:59:16PM -0000, Dave Jones wrote:

> In that case, I agree it should be consistent but wouldn't it be
> preferable to just set
> IMAGE_DEFINITION=".../$IMAGE_PROJECT-$MODEL-$ARCH.yaml" rather than
> conflating $MODEL with $ARCH?

Perhaps, but that sounds like a bigger change and the existing
simplification here is worth doing in its own right provided we fix this
nit?

> Mind you, I'm not 100% clear on what $MODEL really "means" given we also
> have $SUBARCH.

Go fish
-- 
https://code.launchpad.net/~waveform/livecd-rootfs/+git/livecd-rootfs/+merge/450872
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list