[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:enhance-minimize into livecd-rootfs:ubuntu/master

[Philip Roche]

Review: Needs Fixing

Two requests for comments added

Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 12cdb1a..d70f72a 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -292,6 +292,18 @@ if dpkg-query --show --showformat='${db:Status-Status}\n' ubuntu-server 2> /dev/
>      DEBIAN_FRONTEND=noninteractive apt-get install -y landscape-common
>  fi
>  EOF
> +
> +                if [ "$PROJECT" = "ubuntu-cpc" ]; then
> +                  # we'd like to transform a minimized image to a base image
> +                  # when unminimize is run.
> +                  cat >> chroot/usr/local/sbin/unminimize <<'EOF'
> +
> +if ! dpkg-query --show --showformat='${db:Status-Status}\n' ubuntu-server 2> /dev/null | grep -q '^installed$'; then

Can you add a comment here on why we are checking for install rather than just attempting install again even if it is already installed?

> +    echo "Installing ubuntu-server with Recommends to transform this roughly into a base image"
> +    DEBIAN_FRONTEND=noninteractive apt-get --fix-policy install -y ubuntu-server

Can you add a comment here on why we need `--fix-policy`?

> +fi
> +EOF
> +
>  fi
>  		if [ "$PROJECT" = "ubuntu-cpc" ] || [ "$PROJECT" = "ubuntu-server" ]; then
>  			cat >> chroot/usr/local/sbin/unminimize <<'EOF'


-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/450781
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~utkarsh/livecd-rootfs/+git/livecd-rootfs:enhance-minimize into livecd-rootfs:ubuntu/master.