[Merge] ~enr0n/ubuntu/+source/systemd:ubuntu-jammy into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-jammy

Nick Rosbrook mp+455718 at code.launchpad.net
Tue Nov 21 14:20:22 UTC 2023


> Thanks for executing autopkgtests and test builds in a PPA!
> 
> I verified that the patch cherry-picked from upstream matches upstream's logic
> (lp2037281-core-device-ignore-DEVICE_FOUND_UDEV-bit-on-switching-roo.patch),
> so that should be fine.
> 
> Also the logic in the Ubuntu Core read-only-etc hacks patch is looking good to
> me. It's sad that we cannot find a better way around this, other than patching
> systemd. But from reading the bug report comments that seems to be hard. I
> have one remark about this specific patch:

We do have an open PR upstream that's some hope of landing soon enough that I can easily backport it to noble (https://github.com/systemd/systemd/pull/29831).

> - bug #2035122 needs to be integrated in Noble's UBUNTU-read-only-etc-
> hacks.patch.
> => Will this happen with the next systemd merge? Please state your plans in
> the bug report, so it's clear to the SRU team, also target it to the other
> missing series (Lunar, Mantic), marking it WONTFIX, as this only applies to
> Ubuntu Core.

Thanks for the reminder about the bug statuses! And yes, I plan to do this on merge if the above PR is not accepted by then.

> Otherwise, those changes seem to be fine!

Thanks for reviewing!
-- 
https://code.launchpad.net/~enr0n/ubuntu/+source/systemd/+git/systemd/+merge/455718
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-jammy.




More information about the Ubuntu-reviews mailing list