[Merge] ~medicalwei/livecd-rootfs:feat/oem-extra into livecd-rootfs:ubuntu/master

Michael Hudson-Doyle mp+444895 at code.launchpad.net
Thu Jun 29 01:22:09 UTC 2023



Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index 1e45816..8e7a072 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -1547,6 +1570,22 @@ EOF
>  			rm -f config/hooks/*.binary*
>  		fi
>  		;;
> +
> +	ubuntu:oem-*)
> +		# Ensure that most things e.g. includes.chroot are copied as is
> +		for entry in /usr/share/livecd-rootfs/live-build/ubuntu-oem/${SUBPROJECT}/*; do

ubuntu-image/imagecraft is a long way away from being able to build installer images. Speaking as someone who is currently trying to get ubuntu-cdimage going on a local VM I really really wish this was not the case but it is what it is.

Additionally, we want the OEM images to be as close to desktop images as is reasonably possible.

> +			case $entry in
> +				*hooks*)
> +					# But hooks are shared across the projects with symlinks
> +					# dereference them
> +					cp -afL $entry config/
> +					;;
> +				*)
> +					# Most places want to preserve symlinks as is
> +					cp -af $entry config/
> +					;;
> +			esac
> +		done
>  esac
>  
>  case $SUBPROJECT in


-- 
https://code.launchpad.net/~medicalwei/livecd-rootfs/+git/livecd-rootfs/+merge/444895
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~medicalwei/livecd-rootfs:feat/oem-extra into livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list