[Merge] ~logan/ubuntu-dev-tools:ubuntu-distro-info into ubuntu-dev-tools:main
Logan Rosen
mp+445020 at code.launchpad.net
Tue Jun 20 03:22:18 UTC 2023
Logan Rosen has proposed merging ~logan/ubuntu-dev-tools:ubuntu-distro-info into ubuntu-dev-tools:main.
Requested reviews:
Ubuntu Development Team (ubuntu-dev)
For more details, see:
https://code.launchpad.net/~logan/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/445020
As of debootstrap 1.0.128+nmu2ubuntu1.1, there are no longer scripts for each Ubuntu release, and instead it automatically uses the gutsy script if distro-info confirms that it is an Ubuntu release. This is causing the logic in pbuilder-dist to check for a debootstrap script to break and show warnings like the following:
❯ pbuilder-dist mantic update
Warning: Unknown distribution "mantic". Do you want to continue [y|N]? y
To fix this, I've added a check to see if the distro is in the Ubuntu distro data before saying that it is unknown. I also refactored usage of UbuntuDistroData and DebianDistroData to reference a class variable, so they're only instantiated once per execution.
--
Your team Ubuntu Development Team is requested to review the proposed merge of ~logan/ubuntu-dev-tools:ubuntu-distro-info into ubuntu-dev-tools:main.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3440 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230620/10a3c122/attachment.diff>
More information about the Ubuntu-reviews
mailing list