[Merge] ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri

[Mauricio Faria de Oliveira]

Hi Corey,

Thanks for reviewing!

No, I haven't tested upgrades yet. Sorry, I should have clarified I was looking for feedback/comments before checking Victoria (if it's still supported, it'd be needed too; Wallaby+ are good) and doing more testing.

Thanks for the request for upgrade testing, and the suggestion on deprecation notice -- that'd be indeed nice. I had some concerns about introducing an option and not clearly stating its release scope, and the pointer you provided does help.

 17 config_drive_opts = [
 18     cfg.StrOpt('config_drive_format',
 19         default='iso9660',
 20         deprecated_for_removal=True,
 21         deprecated_since='19.0.0',
 22         deprecated_reason="""
 23 This option was originally added as a workaround for bug in libvirt, #1246201,
 24 that was resolved in libvirt v1.2.17. As a result, this option is no longer
 25 necessary or useful.
 26 """,

Given the reasonable feedback, I'll proceed with tests/upgrades and deprecation notice, and push the changes.

I'll be out-of-office Thu-Mon, thus looking to get to it next week.

Thanks again,
Mauricio
-- 
https://code.launchpad.net/~mfo/ubuntu/+source/nova/+git/nova/+merge/447799
Your team Ubuntu OpenStack uploaders is requested to review the proposed merge of ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri.