[Merge] ~utkarsh/livecd-rootfs/+git/livecd-rootfs:ubuntu-cloud-minimal into livecd-rootfs:ubuntu/master

Michael Hudson-Doyle mp+447166 at code.launchpad.net
Thu Jul 20 09:38:57 UTC 2023


Review: Needs Information

I'm sceptical this fixes the problem of cpc images not having the snaps it should.

Diff comments:

> diff --git a/live-build/auto/config b/live-build/auto/config
> index f881cc8..b5c722a 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -1210,7 +1209,11 @@ case $PROJECT:${SUBPROJECT:-} in
>  		BASE_SEED='wsl'
>  		;;
>  	ubuntu-cpc:*)
> -		BASE_SEED='server'
> +		# we don't preseed any snaps in minimized images, so no need to set
> +		# BASE_SEED in that case.
> +		if [ "${SUBPROJECT:-}" != minimized ]; then
> +			BASE_SEED='server'

Does this actually work? We don't really actually use BASE_SEED for anything any more, just some crufty ubiquity-style minimal related stuff. If you want the snaps from the server seed you should add_task the server task (which gets the packages too of course, but you have those already because the cloud-image seed includes the ubuntu-server package). We could probably add a way to only get the seeds from a task, not the debs but uh. Let's not do that.

> +		fi
>  		;;
>  	ubuntu-server:live)
>  		BASE_SEED='server'


-- 
https://code.launchpad.net/~utkarsh/livecd-rootfs/+git/livecd-rootfs/+merge/447166
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~utkarsh/livecd-rootfs/+git/livecd-rootfs:ubuntu-cloud-minimal into livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list