[Merge] ~xypron/livecd-rootfs:sunset_allwinner_flavour into livecd-rootfs:ubuntu/master

Dimitri John Ledkov mp+445903 at code.launchpad.net
Wed Jul 5 12:40:46 UTC 2023


Review: Needs Fixing

my preference would be to keep the strict check though, as in other places we already support declaring one flavour but a different kernel metapackage.

since auto/build affects all builds, not just riscv ones.

Can you please change this merge proposal as follows:

1) Drop bea231e commit
2) In live-build/auto/build 

modify

for FLAVOUR in $LB_LINUX_FLAVOURS; do
        if [ -z "$LB_LINUX_FLAVOURS" ] || [ "$LB_LINUX_FLAVOURS" = "none" ]; then
                continue
        fi
        case $FLAVOUR in
                virtual|generic-hwe-*)
                        FLAVOUR="generic"
                        ;;
                oem-*)
                        FLAVOUR="oem"
                        ;;
                image-intel)
                        FLAVOUR="intel"
                        ;;
                intel-iotg*)
                        FLAVOUR="intel-iotg"
                        ;;
        esac


And add allwinner in the case that sets flavour generic, i.e. such that it becomes "allwinner|virtual|generic-hwe-*)" ?

This will ensure that strict checking is still in place, for the expected kernel flavour abi, whilst also the correct metapackage is installed.


-- 
https://code.launchpad.net/~xypron/livecd-rootfs/+git/livecd-rootfs/+merge/445903
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list