[Merge] ~ubuntustudio-dev/livecd-rootfs:studio-new-installer into livecd-rootfs:ubuntu/master
Erich Eickmeyer
mp+456901 at code.launchpad.net
Tue Dec 5 19:57:27 UTC 2023
Before I make changes, question inline.
Diff comments:
> diff --git a/live-build/auto/config b/live-build/auto/config
> index 20e280b..907def6 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -846,8 +846,28 @@ case $PROJECT in
> ;;
>
> ubuntustudio-dvd)
> - add_task install minimal standard ubuntustudio-desktop ubuntustudio-audio ubuntustudio-graphics ubuntustudio-video ubuntustudio-photography
> + # By default Ubuntu Studio now ships the new installer.
> + touch config/universe-enabled
> + PASSES_TO_LAYERS="true"
> KERNEL_FLAVOURS=lowlatency
> + add_task standard ubuntustudio-desktop ubuntustudio-audio ubuntustudio-graphics ubuntustudio-video ubuntustudio-photography
> + add_task standard.live ubuntustudio-live
> + add_package cloud-init
> + remove_package standard.live ubiquity-fronted-gtk
> + add_snap standard.live ubuntustudio-system-installer/classic
> + add_package standard.live linux-$KERNEL_FLAVOURS casper
This raises a question. That doesn't match what Budgie has in the code lines above in the same file (lines 812-815):
add_package minimal cloud-init
remove_package minimal.standard.live ubiquity-frontend-gtk
add_snap minimal.standard.live ubuntu-budgie-installer/classic
add_package minimal.standard.live linux-$KERNEL_FLAVOURS casper
They certainly doen't have any of that in their seed (I checked) and the live seeds do not populate snaps (only the desktop seed has the ability to do that iiui). Therefore, why would I put this in the seeds as opposed to mirroring what Lukasz has already put in the code in the same file above?
> + cat <<-EOF > config/standard.catalog-in.yaml
> + name: "Ubuntu Studio Desktop"
> + description: >-
> + A full featured Ubuntu Studio Desktop.
> + id: ubuntustudio-desktop
> + type: fsimage-layered
> + variant: desktop
> + locale_support: langpack
> + default: yes
> + EOF
> + /usr/share/livecd-rootfs/checkout-translations-branch \
> + https://git.launchpad.net/subiquity po config/catalog-translations
> ;;
>
> ubuntu-server)
--
https://code.launchpad.net/~ubuntustudio-dev/livecd-rootfs/+git/livecd-rootfs/+merge/456901
Your team Ubuntu Studio Development is subscribed to branch ~ubuntustudio-dev/livecd-rootfs:studio-new-installer.
More information about the Ubuntu-reviews
mailing list