[Merge] ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri

[Mauricio Faria de Oliveira]

Hey Corey,

Thanks for reviewing again.

> Can we add this to ALL_OPTS so that it is processed under the [workarounds] section? Curious why you introduced DEFAULT_OPTS.

I previously looked at keeping the option under the two groups (defaults and workarounds), but IIRC this actually created 2 different options (ie, the value/setting wasn't synchronized between both).

I introduced it into DEFAULT_OPTS for better integration with the nova-compute charm's config-flags option (which works with the DEFAULTS section AFAICT from its help text), so it can be set easily and consistently in (juju) deployments, which is the more likely consumer of this.

> Do you know how this behaves if the config option is still enabled and upgraded from victoria->wallaby?

I just tested an upgrade from Victoria to Wallaby. The option remains set (as the charm's config-flags option still carries it), but it has no effect, as the package upgrade overwrites the patched file in Ussuri/Victoria.
(And Wallaby and later use a different code/approach for this, due to proper Secure Boot support/spec implemented.)

We could also patch the nova-compute charm to automatically remove this option from config-flags on upgrades from U/V to W+.

Thanks!
Mauricio

-- 
https://code.launchpad.net/~mfo/ubuntu/+source/nova/+git/nova/+merge/447799
Your team Ubuntu OpenStack uploaders is requested to review the proposed merge of ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri.