[Merge] ~jessica-youjeong/livecd-rootfs:062223-jammy-snap-preseeding into livecd-rootfs:ubuntu/jammy

Michael Hudson-Doyle mp+446329 at code.launchpad.net
Fri Aug 11 03:13:39 UTC 2023


I think this is broadly OK but there is one thing I don't really like (see comment) and I'd prefer to wait until all dailies have built in mantic with 23.10.13.

Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index 17f2b07..18229e3 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -777,6 +780,14 @@ snap_validate_seed() {
>          /usr/lib/snapd/snap-preseed $(realpath "${CHROOT_ROOT}")
>          chroot "${CHROOT_ROOT}" apparmor_parser --skip-read-cache --write-cache --skip-kernel-load --verbose  -j `nproc` /etc/apparmor.d
>      fi
> +
> +    # Unmount kernel specific apparmor feature
> +    # mount generic apparmor feature again (cleanup)
> +    if [ -d /build/config/hooks.d/extra/apparmor/${kern_major_min} ]; then

As I just said on the MP for master, I think this only works by chance if we don't fall into the "-e ${CHROOT_ROOT}/boot/vmlinuz" case. But I guess it does work so...

> +        umount "${CHROOT_ROOT}/sys/kernel/security/apparmor/features/"
> +        mount -o bind /usr/share/livecd-rootfs/live-build/apparmor/generic "${CHROOT_ROOT}/sys/kernel/security/apparmor/features/"
> +    fi
> +
>  }
>  
>  snap_from_seed() {


-- 
https://code.launchpad.net/~jessica-youjeong/livecd-rootfs/+git/livecd-rootfs/+merge/446329
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jessica-youjeong/livecd-rootfs:062223-jammy-snap-preseeding into livecd-rootfs:ubuntu/jammy.




More information about the Ubuntu-reviews mailing list