[Merge] ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri

[Mauricio Faria de Oliveira]

Hey Corey,

- added the deprecation notice and confirmed it is reflected in nova.conf (see below).
- (re)tested Ussuri and Victoria (yes, it's affected / needs fixing for upgrade path).
- tested the upgrade path from Ussuri to Victoria, and the patch works correctly too.

The detailed test steps/results are in bug 1960758 comments #15, #16, and #17.

If this looks good to you, I'm happy to send it for review upstream too, if Ubuntu
specific patches are welcome for review. (I realize Ubuntu is popular on Openstack.)

And I can send a MR for Victoria too, depending on your feedback.

Please let me know the next steps.

Thanks!
Mauricio

...

Patch changes to the nova.conf file:

Old package:

	$ pull-lp-debs nova-common focal
	$ dpkg-deb -x nova-common_21.2.4-0ubuntu2.5_all.deb deb-old

New package:

	$ dpkg-buildpackage ...
	$ dpkg-deb -x nova-common_21.2.4-0ubuntu2.6_all.deb deb-new

The new config option is present with a deprecation notice.

	$ diff -u deb-{old,new}/etc/nova/nova.conf
	...
	+# DEPRECATED:
	+# Determine UEFI loader path list for images with hw_firmware_type=uefi. For
	+# more information, refer to the documentation. (boolean value)
	+# This option is deprecated for removal since 21.2.4.
	+# Its value may be silently ignored in the future.
	+# Reason:
	+# This option was added to work around issues with booting UEFI instances
	+# in Ussuri and Victoria (LP: #1960758) if the Secure Boot loader is used
	+# (happens by default on Ubuntu 20.04). This option does not exist nor is
	+# needed in Wallaby and later, which actually support Secure Boot.
	+#ubuntu_libvirt_uefi_loader_path = false
	+
	...
-- 
https://code.launchpad.net/~mfo/ubuntu/+source/nova/+git/nova/+merge/447799
Your team Ubuntu OpenStack uploaders is requested to review the proposed merge of ~mfo/ubuntu/+source/nova:lp1960758-ussuri into ~ubuntu-openstack-dev/ubuntu/+source/nova:stable/ussuri.