[Merge] ~chad.smith/livecd-rootfs:cloud-init-desktop-use-netplan into livecd-rootfs:ubuntu/master

Chad Smith mp+440613 at code.launchpad.net
Fri Apr 7 22:26:16 UTC 2023


Chad Smith has proposed merging ~chad.smith/livecd-rootfs:cloud-init-desktop-use-netplan into livecd-rootfs:ubuntu/master.

Commit message:
cloud-init: prefer netplan to handle all network manager config

Cloud-init cannot write directly to
/etc/NetworkManager/system-connections because subiquity may
need to emit config to /etc/netplan/00-installer.yaml and call
netplan apply for autoinstall.network use-cases.

When cloud-init's config is written directly to
/etc/NetworkManager, neither netplan nor subiquity has knowledge of
this config and this results in namespace collisions in NetworkManager
due to `netplan-` named connections and `cloud-init` connection ids
fighting over which config own a given interface name.

Deleting this config overlay allows subiquity to manage all network
setup when it needs to with netplan directly.

Subiquity already has logic to rename any unwanted netplan
configuration when it intends to write cfg and run netplan apply[1].
This should allow subiquity full control of network config when needed.

[1] https://github.com/canonical/subiquity/blob/
    92ac6544cdfedfd332d8cd94dbcfad0aab994575/subiquitycore/
        controllers/network.py#L267

LP: #2015605


Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #2015605 in cloud-init: "desktop live installer: cloud-init/ubuntu-desktop-installer network config naming collisions"
  https://bugs.launchpad.net/cloud-init/+bug/2015605

For more details, see:
https://code.launchpad.net/~chad.smith/livecd-rootfs/+git/livecd-rootfs/+merge/440613
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~chad.smith/livecd-rootfs:cloud-init-desktop-use-netplan into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 749 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230407/a4b91f1b/attachment.diff>


More information about the Ubuntu-reviews mailing list