[Merge] ~jchittum/livecd-rootfs:jammy-support-for-multi-apparmor-features into livecd-rootfs:ubuntu/jammy

John Chittum mp+440607 at code.launchpad.net
Fri Apr 7 20:03:19 UTC 2023


John Chittum has proposed merging ~jchittum/livecd-rootfs:jammy-support-for-multi-apparmor-features into livecd-rootfs:ubuntu/jammy.

Commit message:
fix: add multi kernel apparmor features

fixes LP: 2015596

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/440607

tested using CPC builds

1. added `snap_preseed_validate` to the end of a CPC build hook (ec2)

2. built the image: 

bartender --hook-extras-dir ~/dev01/cloudware/cpc_packaging.extra --livecd-rootfs-dir ~/dev01/livecd-rootfs --build-provider aws --aws-keypair-name jchittum-cpc-jenkins -- --series jammy --project ubuntu-cpc --image-target ec2

3. registered the image in ec2

4. ran our test suite. This includes a check of `snap debug seeding` which will show if there is a mismatch in kernel apparmor features and if the system needs a reboot to be properly seeded

Test passed with:

'snap debug timing' stdout':
{'image-preseeding': '9.238s',
 'preseeded': True,
 'seed-completion': '9.726s',
 'seeded': True}
======================================================================
Summary
======================================================================
Success? True
----------------------------------------------------------------------
SKIPPED: __main__.BasicUbuntuTests.test_fstab_ESP_umask
System is not EFI, not testing ESP mount option
------------------------------------------------


Failed Test:

'preseed-system-key': {'apparmor-features': ['caps', 'dbus', 'domain', 'file',
                                           'mount', 'namespaces', 'network',
                                           'network_v8', 'policy', 'ptrace',
                                           'query', 'rlimit', 'signal'],
                     'apparmor-parser-features': ['cap-audit-read',
                                                  'cap-bpf', 'mqueue',
                                                  'qipcrtr-socket', 'unsafe',
                                                  'xdp'],
                     'apparmor-parser-mtime': 1666191120,
                     'build-id': '79b62e11a4cf60b38c3e2449d220a6078db42607',
                     'cgroup-version': '2',
                     'nfs-home': False,
                     'overlay-root': '',
                     'seccomp-compiler-version': 'd9242946c125eab1ac4e30a3a7f48ee885551585 '
                                                 '2.5.4 '
                                                 'c3c9b282ef3c8dfcc3124b2aeaef62f56b813bfd21f8806b30a6c9dbc2e6e58d '
                                                 'bpf-actlog',
                     'seccomp-features': ['allow', 'errno', 'kill_process',
                                          'kill_thread', 'log', 'trace',
                                          'trap', 'user_notif'],
                     'version': 10},
'preseeded': True,
'seed-completion': '5.765s',
'seed-restart-system-key': {'apparmor-features': ['caps', 'dbus', 'domain',
                                                'file', 'ipc', 'mount',
                                                'namespaces', 'network',
                                                'network_v8', 'policy',
                                                'ptrace', 'query', 'rlimit',
                                                'signal'],
                          'apparmor-parser-features': ['cap-audit-read',
                                                       'cap-bpf', 'mqueue',
                                                       'qipcrtr-socket',
                                                       'unsafe', 'xdp'],
                          'apparmor-parser-mtime': 1666191120,
                          'build-id': '79b62e11a4cf60b38c3e2449d220a6078db42607',
                          'cgroup-version': '2',
                          'nfs-home': False,
                          'overlay-root': '',
                          'seccomp-compiler-version': 'd9242946c125eab1ac4e30a3a7f48ee885551585 '
                                                      '2.5.4 '
                                                      'c3c9b282ef3c8dfcc3124b2aeaef62f56b813bfd21f8806b30a6c9dbc2e6e58d '
                                                      'bpf-actlog',
                          'seccomp-features': ['allow', 'errno',
                                               'kill_process', 'kill_thread',
                                               'log', 'trace', 'trap',
                                               'user_notif'],
                          'version': 10},
'seeded': True}


-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jchittum/livecd-rootfs:jammy-support-for-multi-apparmor-features into livecd-rootfs:ubuntu/jammy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2010 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20230407/6ad8881d/attachment.diff>


More information about the Ubuntu-reviews mailing list