[Merge] ~itrue/livecd-rootfs:add-nemos-support-v2 into livecd-rootfs:ubuntu/master
Loïc Minier
mp+440477 at code.launchpad.net
Thu Apr 6 11:09:57 UTC 2023
Review: Approve
Outside of dropping lsb_release, I think this looks super clean and is ready for merging, thanks!
Diff comments:
> diff --git a/live-build/auto/config b/live-build/auto/config
> index db1da0d..bc5ae0a 100755
> --- a/live-build/auto/config
> +++ b/live-build/auto/config
> @@ -548,6 +596,41 @@ case $IMAGEFORMAT in
> exit 0
> ;;
>
> + kiwi)
> + if [ -z "${KIWI_PLATFORM}" ]; then
> + echo "KIWI_PLATFORM must be set when IMAGEFORMAT=kiwi"
> + exit 1
> + fi
> +
> + if [ -z "${KIWI_PROJECT}" ]; then
> + echo "KIWI_PROJECT must be set when IMAGEFORMAT=kiwi"
> + exit 1
> + fi
> +
> + if [ -z "${SUITE}" ]; then
> + SUITE=$(lsb_release -c -s)
this should just rely on SUITE rather than run lsb_release
> + fi
> +
> + if [ -z "${KIWI_ROOT}" ]; then
> + KIWI_ROOT="/usr/share/kiwi/${PROJECT}"
> + fi
> +
> + echo "KIWI_PLATFORM=\"${KIWI_PLATFORM}\"" >> config/common
> + echo "KIWI_PROFILE=\"${KIWI_PROFILE:-}\"" >> config/common
> + echo "KIWI_PROJECT=\"${KIWI_PROJECT}-${SUITE}\"" >> config/common
> + echo "KIWI_ROOT=\"${KIWI_ROOT}\"" >> config/common
> + echo "IMAGEFORMAT=\"${IMAGEFORMAT}\"" >> config/common
> +
> + echo "Kiwi configuration:"
> + echo " Platform: ${KIWI_PLATFORM}"
> + echo " Project: ${KIWI_PROJECT}"
> + echo " Project root: ${KIWI_ROOT}"
> + echo " Build profile: ${KIWI_PROFILE:-none}"
> +
> + # No further configuration needed
> + exit 0
> + ;;
> +
> none)
> # Currently the IMAGEFORMAT none format is used only for ubuntu-image
> # targeted image builds which, currently, only target physical devices.
--
https://code.launchpad.net/~itrue/livecd-rootfs/+git/livecd-rootfs/+merge/440477
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.
More information about the Ubuntu-reviews
mailing list