[Merge] ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master

Cristovao Cordeiro mp+430736 at code.launchpad.net
Thu Sep 29 12:50:09 UTC 2022


Review: Needs Fixing



Diff comments:

> diff --git a/live-build/auto/build b/live-build/auto/build
> index 9c1f0fc..9326849 100755
> --- a/live-build/auto/build
> +++ b/live-build/auto/build
> @@ -462,7 +462,12 @@ EOF
>  		fi
>  
>  		if [ "$PROJECT" = "ubuntu-oci" ]; then
> -		    configure_oci chroot
> +			if ! [ -z "$BUILDSTAMP" ]; then
> +				 configure_oci chroot $BUILDSTAMP

bad indentation

> +			else
> +				echo "The serial is empty"
> +				exit 1
> +			fi  
>  		fi
>  
>  		configure_network_manager


-- 
https://code.launchpad.net/~samirakarioh/livecd-rootfs/+git/livecd-rootfs/+merge/430736
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master.




More information about the Ubuntu-reviews mailing list