[Merge] ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master

[Cristovao Cordeiro]

Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index 3de9857..a6d88b9 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -931,6 +932,15 @@ configure_oci() {
>      echo 'exit 101' >> ${chroot}/usr/sbin/policy-rc.d
>      Chroot ${chroot} "chmod +x /usr/sbin/policy-rc.d"
>  
> +
> +    if ! [ -z "$serial" ];
> +    then
> +    # create a folder /etc/cloud and add a build.info file in it with the serial of the image

this is a good point. I'm unsure about it. Rationally, yes! But is that this function's job? It feels like this assertion should happen someplace else.

At the same time, it's harmless to have it here (even if it becomes redundant). I'd also say to go for it -> echo an error message and exit 1

> +        mkdir ${chroot}/etc/cloud
> +        cat > ${chroot}/etc/cloud/build.info << EOF
> +serial: $serial
> +EOF
> +    fi
>      # https://github.com/docker/docker/blob/9a9fc01af8fb5d98b8eec0740716226fadb3735c/contrib/mkimage/debootstrap#L54-L56
>      Chroot ${chroot} "dpkg-divert --local --rename --add /sbin/initctl"
>      cp -a ${chroot}/usr/sbin/policy-rc.d ${chroot}/sbin/initctl


-- 
https://code.launchpad.net/~samirakarioh/livecd-rootfs/+git/livecd-rootfs/+merge/430736
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master.