[Merge] ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master

[Thomas Bechtold]

Review: Needs Fixing



Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index 3de9857..25383d4 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -923,6 +923,7 @@ configure_oci() {
>      # at https://github.com/tianon/docker-brew-ubuntu-core/blob/master/update.sh
>  
>      local chroot=$1
> +    local serial=$2

can we check here that $serial is not empty? Otherwise we might write a file that contains nothing.

>  
>      echo "==== Configuring OCI ===="
>  


-- 
https://code.launchpad.net/~samirakarioh/livecd-rootfs/+git/livecd-rootfs/+merge/430736
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~samirakarioh/livecd-rootfs:add-metadata-rocks into livecd-rootfs:ubuntu/master.