[Merge] ~mustafakemalgilor/ubuntu/+source/systemd:systemd-fix-lp1978079-efi-pstore-not-cleared-jammy into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-jammy

[Mustafa Kemal Gilor]

Mustafa Kemal Gilor has proposed merging ~mustafakemalgilor/ubuntu/+source/systemd:systemd-fix-lp1978079-efi-pstore-not-cleared-jammy into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-jammy.

Requested reviews:
  Canonical Server Core Reviewers (canonical-server-core-reviewers)
  Canonical Server (canonical-server)
Related bugs:
  Bug #1978079 in systemd (Ubuntu): "EFI pstore not cleared on boot"
  https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1978079

For more details, see:
https://code.launchpad.net/~mustafakemalgilor/ubuntu/+source/systemd/+git/systemd/+merge/425082

Backported a fix from upstream to jammy for the LP issue #1978079:

      * d/p/lp1978079-efi-pstore-not-cleared-on-boot.patch: pstore: Run 
        after
        modules are loaded. Thanks to Alexander Graf <graf at amazon.com>.
        LP: #1978079)

Please tag & sponsor.

(See backport merge request for focal: https://code.launchpad.net/~mustafakemalgilor/ubuntu/+source/systemd/+git/systemd/+merge/424938)

Steps to reproduce/test:

# In order to be able to reproduce this issue, the system must have EFI-backed pstore.
# To check which kind of backend that pstore, use `cat /sys/module/pstore/parameters/backend`
# If it says `efi`, the steps below are applicable. Otherwise, find an environment that has
# EFI backed pstore.

# Enable the pstore service. This service is supposed to move the data in /sys/fs/pstore
# to the `/var/lib/systemd/pstore` path on boot.
systemctl enable systemd-pstore.service # (or can be vendor enabled)

# Crash the kernel
echo 1 > /proc/sys/kernel/sysrq
echo 1 > /proc/sys/kernel/panic # this is usually set to zero, causing kernel to loop over the panic and freeze
echo "c" > /proc/sysrq-trigger

# The system will reboot itself. Check `/sys/fs/pstore` path first:
ls /sys/fs/pstore # The path should not be empty, which means the systemd-pstore has failed to do its' job
ls /var/lib/systemd/pstore # The path should be empty.

# Apply the fix
sudo add-apt-repository ppa:mustafakemalgilor/lp-1978079-1
sudo apt upgrade

# Crash the kernel
echo 1 > /proc/sys/kernel/sysrq
echo 1 > /proc/sys/kernel/panic # this is usually set to zero, causing kernel to loop over the panic and freeze
echo "c" > /proc/sysrq-trigger

# The system will reboot itself. Check `/sys/fs/pstore` path first:
ls /sys/fs/pstore # The path should be empty
ls /var/lib/systemd/pstore # The path should not be empty

Package Test Results:

autopkgtest [15:49:45]: test systemd-fsckd: [-----------------------
SKIP: root file system is being checked by initramfs already
autopkgtest [15:49:45]: test systemd-fsckd: -----------------------]
systemd-fsckd        SKIP exit status 77 and marked as skippable
autopkgtest [15:49:46]: test systemd-fsckd:  - - - - - - - - - - results - - - - - - - - - -
autopkgtest [15:49:46]: @@@@@@@@@@@@@@@@@@@@ summary
timedated            PASS
hostnamed            PASS
localed-locale       PASS
localed-x11-keymap   PASS
logind               PASS
unit-config          PASS
storage              PASS
networkd-test.py     PASS
build-login          PASS
boot-and-services    PASS
udev                 PASS
unit-tests           PASS
tests-in-lxd         PASS
upstream-1           PASS
upstream-2           PASS
boot-smoke           PASS
systemd-fsckd        SKIP exit status 77 and marked as skippable
qemu-system-x86_64: terminating on signal 15 from pid 474221 (/usr/bin/python3)
-- 
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-jammy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3374 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20220620/b049f409/attachment-0001.diff>