[Merge] ~alexghiti/ubuntu-seeds/+git/ubuntu:int/alex/riscv_wpasupplicant into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:kinetic

Ɓukasz Zemczak mp+427162 at code.launchpad.net
Tue Jul 26 15:20:22 UTC 2022

Review: Disapprove

hm, I'm worried this is not the right place for it. Seeds are a bit tricky, but looking at livecd-rootfs code, I don't think our code-paths of preinstalled server images actually install server-minimal in any way. The server-minimal seed seems to be only used by the ubuntu-server-minimal metapackage and the Ubuntu Server live-installer (subiquity). For preinstalled server builds, we actually build via the ubuntu-cpc project name - and this installs seeds such as minimal, standard, cloud-image and the ubuntu-minimal metapackage. And none of these use server-minimal in any way. Weirdly, we even do not install the server seed on our riscv64 images!

I think the best way forward was to maybe tweak livecd-rootfs to use the 'server' seed and then add wpasupplicant there... But then, we'd either have to do it board-specific specific or ask the Public Cloud team if they'd be fine to pull in for every riscv64 cpc image we build.

eh, I think I'm starting to lean toward just doing it in livecd-rootfs. I didn't want that and it was me telling you I'd prefer to do it via seeds, but seeing the additional problems, it feels to me this late in the cycle this might be the easier way.
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~alexghiti/ubuntu-seeds/+git/ubuntu:int/alex/riscv_wpasupplicant into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:kinetic.

More information about the Ubuntu-reviews mailing list