[Merge] ~mirespace/ubuntu/+source/amavisd-new:merge-lp1946841-jammy into ubuntu/+source/amavisd-new:debian/sid

Fri Feb 18 18:11:02 UTC 2022

You have been requested to review the proposed merge of ~mirespace/ubuntu/+source/amavisd-new:merge-lp1946841-jammy into ubuntu/+source/amavisd-new:debian/sid.

For more details, see:
https://code.launchpad.net/~mirespace/ubuntu/+source/amavisd-new/+git/amavisd-new/+merge/415808

Hello team,

thanks in advance for the time in this review. When this MP seems enough good to you, please tag & sponsor. 

PPA for this merge is:
   https://launchpad.net/~mirespace/+archive/ubuntu/merge-amavisd-new-1-2.12.2-1ubuntu1-jammy-lp1946841
   ppa:mirespace/merge-amavisd-new-1-2.12.2-1ubuntu1-jammy-lp1946841

There you can find a built for amd64. 

No lintian errors: 
❯ lintian --pedantic --display-info --verbose --info --profile ubuntu ../amavisd-new_2.12.2-1ubuntu1.dsc
N: Using profile ubuntu/main.
N: Starting on group amavisd-new/1:2.12.2-1ubuntu1
N: Unpacking packages in group amavisd-new/1:2.12.2-1ubuntu1
N: Finished processing group amavisd-new/1:2.12.2-1ubuntu1
N: ----
N: Processing source package amavisd-new
N: (version 1:2.12.2-1ubuntu1, arch source) ...
I: amavisd-new source: testsuite-autopkgtest-missing
N:
N:    This package does not declare a test suite.
N:
N:    Having a test suite aids with automated quality assurance of the archive
N:    outside of your package. For example, if your package has a test suite
N:    it is possible to re-run that test suite when any of your package's
N:    dependencies have a new version and check whether that update causes
N:    problems for your package.
N:
N:    In addition, since May 2018 these tests now influence migration from
N:    unstable to testing:
N:
N:     https://lists.debian.org/debian-devel-announce/2018/05/msg00001.html
N:
N:    Please add a debian/tests/control file to your package to declare a
N:    testsuite, but please make sure to only add autopkgtests if they provide
N:    meaningful coverage of your package.
N:
N:    Refer to https://ci.debian.net/doc/ for details.
N:
N:    Severity: info
N:
N:    Check: testsuite
N:
I: amavisd-new source: upstream-metadata-missing-bug-tracking
N:
N:    The DEP 12 metadata file does not specify any upstream bug tracking
N:    information (ie. the Bug-Database or Bug-Submit fields are missing).
N:
N:    The upstream metadata can be found in the source package in the file
N:    debian/upstream/metadata.
N:
N:    Refer to https://dep-team.pages.debian.net/deps/dep12/ for details.
N:
N:    Severity: info
N:
N:    Check: debian/upstream/metadata
N:
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 342)
N:
N:    This file appears to contain one or more lines with trailing whitespace
N:    characters.
N:
N:    Whilst typically harmless and merely unsightly, they can often cause
N:    difficult-to-spot issues where tools interpret the whitespace characters
N:    literally as well as introduce unnecessary diff(1) noise. They are thus
N:    best avoided in their entirity.
N:
N:    Whitespace at the end of lines may be removed with the following:
N:
N:     $ sed -i -e 's@[[:space:]]$@@g' debian/control debian/changelog
N:
N:    If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N:    However, if you wish to only remove trailing spaces and leave trailing
N:    tabs (eg. for Makefiles), you can use the following code snippet:
N:
N:     $ sed -i -e 's@[ ]$@@g' debian/rules
N:
N:    To remove empty lines from the end of a file, you can use:
N:
N:     $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N:    Severity: pedantic
N:
N:    Check: cruft
N:
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 350)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 351)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 376)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 820)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 838)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 846)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 852)
P: amavisd-new source: file-contains-trailing-whitespace debian/changelog (line 955)
P: amavisd-new source: no-dep5-copyright
N:
N:    This package does not use a machine-readable debian/copyright file.
N:
N:    This format makes it easier to review licenses and can be easily parsed
N:    by Lintian.
N:
N:    Refer to
N:    https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:    details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/copyright
N:
P: amavisd-new source: package-uses-experimental-debhelper-compat-version 13
N:
N:    The debhelper compatibility version used by this package is marked as
N:    experimental by the debhelper developer. You should consider using a
N:    stable compatibility version instead.
N:
N:    The compatibility version can be set by specifying debhelper-compat (=
N:    12) in your package's Build-Depends, by the legacy debian/compat file or
N:    even by setting and exporting DH_COMPAT in debian/rules. If it is not
N:    set in either place, debhelper defaults to the deprecated compatibility
N:    version 1.
N:
N:    Refer to the debhelper(7) manual page for details.
N:
N:    Severity: pedantic
N:
N:    Check: debhelper
N:
P: amavisd-new source: rules-requires-root-missing
N:
N:    The debian/control file is missing an explicit Rules-Requires-Root
N:    field.
N:
N:    Traditionally, Debian packages have required root privileges for some
N:    debian/rules target requiring a split between build and binary targets.
N:    This makes the builds slower due to the increased amount of invocations
N:    as well as the overhead of fakeroot itself.
N:
N:    Please specify (eg.) Rules-Requires-Root: no in the debian/control
N:    source stanza, but packagers should verify using diffoscope(1) that the
N:    binaries built with this field present are identical.
N:
N:    Refer to /usr/share/doc/dpkg-dev/rootless-builds.txt.gz, Debian Policy
N:    Manual section 4.9.2 (debian/rules and Rules-Requires-Root), and Debian
N:    Policy Manual section 5.6.31 (Rules-Requires-Root) for details.
N:
N:    Severity: pedantic
N:
N:    Check: debian/control
N:

The package hasn't got DEP-8 tests (the bug 1677700 is open for this).

I checked the upgraded paths (upgrading and installing from scratch), and both were OK:

root at jammy:~# apt list --upgradable -a
Listing... Done
amavisd-new/jammy 1:2.12.2-1ubuntu1 all [upgradable from: 1:2.11.1-5ubuntu1]
amavisd-new/jammy,now 1:2.11.1-5ubuntu1 all [installed,upgradable to: 1:2.12.2-1ubuntu1]

After install/upgrading:

root at jammy:~# systemctl status amavis
● amavis.service - Interface between MTA and virus scanner/content filters
     Loaded: loaded (/lib/systemd/system/amavis.service; enabled; vendor preset: enabled)
     Active: active (running) since Fri 2022-02-18 16:04:58 UTC; 1h 4min ago
       Docs: http://www.ijs.si/software/amavisd/#doc
    Process: 21333 ExecStartPre=/usr/bin/find /var/lib/amavis -maxdepth 1 -name amavis-* -type d -exec rm -rf {} ; (code=exited, status=0/SU>
    Process: 21334 ExecStartPre=/usr/bin/find /var/lib/amavis/tmp -maxdepth 1 -name amavis-* -type d -exec rm -rf {} ; (code=exited, status=>
   Main PID: 21335 (/usr/sbin/amavi)
      Tasks: 3 (limit: 76983)
     Memory: 61.8M
     CGroup: /system.slice/amavis.service
             ├─21335 "/usr/sbin/amavisd-new (master)"
             ├─21382 "/usr/sbin/amavisd-new (virgin child)"
             └─21383 "/usr/sbin/amavisd-new (virgin child)"

Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .iso
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .jar
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .lha
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .lrz
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .lz4
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .lzo
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .rar
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .rpm
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .swf
Feb 18 16:04:58 jammy amavis[21335]: No decoder for       .zoo
root at jammy:~# netstat -lnpt | grep amavis
tcp        0      0 127.0.0.1:10024         0.0.0.0:*               LISTEN      21335/amavisd-new ( 
tcp6       0      0 ::1:10024               :::*                    LISTEN      21335/amavisd-new ( 
root at jammy:~# amavisd-new -V
amavisd-new-2.12.2 (20211013)
root at jammy:~# 

About the delta, I squashed as requested the following:

  * Added:
    - d/amavisd-new-postfix.postrm: add #DEBHELPER# to the end of the script.
      [squash this change with "amavisd-new-postfix configuration for
       anti-spam/virus" (4e84c665522d1be) in the next merge]
    - d/amavisd-new-postfix.*: use a FHS compliant dir to store backup files.
      [squash this change with "amavisd-new-postfix configuration for
       anti-spam/virus" (4e84c665522d1be) in the next merge]

The rest remains the same.

Looking at the current bugs for this package, I replied to bug 1576041
and the bug 1481579 will be closed automatically due to the solution proposed 
by @Sergiodj was accepted by upstream (\o/).

-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~mirespace/ubuntu/+source/amavisd-new:merge-lp1946841-jammy into ubuntu/+source/amavisd-new:debian/sid.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 46749 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20220218/ee1f0f2e/attachment-0001.diff>