[Merge] lp:~khurshid-alam/indicator-sound/fix-build-impish into lp:indicator-sound

[Khurshid Alam]

Khurshid Alam has proposed merging lp:~khurshid-alam/indicator-sound/fix-build-impish into lp:indicator-sound.

Commit message:
* Fix build against vala > 48 & vala >= 50

* Add symbolic icons to the tests

* Avoid possible null value in Greeterlist and GreeterBroadcast object.
  
  See https://github.com/AyatanaIndicators/ayatana-indicator-sound/commit/8df9168f5587cfd31e0bf6a4170a4c4f9784dbb7

* Fix build against GLib > 2.64: Replace HashTable with GenericSet

* Fix static member access

* Drop deprecated DBusProxy.create_for_bus

* Add libdbustest-1 include path

* Unit Tests: Unset environment variable and session bus in teardown

* debian/control: Remove qt5-default & add libgmock-dev in build depends. See https://bugs.launchpad.net/bugs/1921781

* Unit Tests: The desktop pulseaudio daemon also needs the stream-restore module these days

* Unit Tests: Disable notification tests that can not be fixed now. Most of them are phone related and depends on liburl-dispatcher library which was dropped from code since it is no longer in the universe repository. See https://bazaar.launchpad.net/~indicator-applet-developers/indicator-sound/trunk.16.10/revision/564

*   Unit Tests: Disable indicator tests that can not be fixed now. These tests needs to be re-enabled later
   - tests/indicator-test.cc:PhoneMenu
   - tests/indicator-test.cc:DesktopMenu
   - tests/indicator-test.cc:BaseActions
   - tests/integration/test-indicator.cpp:All tests
   - tests/volume-control-test.cc:BasicObject

* debian/rules: Re enable live tests logs



Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)

For more details, see:
https://code.launchpad.net/~khurshid-alam/indicator-sound/fix-build-impish/+merge/409379

Regarding tests, most only works on unity-8/phone environment and some are failing due to bugs libdbustest and gmock. As per my testing this doesn't hamper functionality on desktop, indicator-sound works as expected. These tests can be enabled for desktop later if someone able to fix those.
-- 
Your team Indicator Applet Developers is requested to review the proposed merge of lp:~khurshid-alam/indicator-sound/fix-build-impish into lp:indicator-sound.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 43004 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20210929/837bdb74/attachment-0001.diff>