[Merge] ~chad.smith/software-properties:ua-status-from-json-focal into software-properties:ubuntu/focal

Chad Smith mp+411049 at code.launchpad.net
Fri Oct 29 22:41:23 UTC 2021


Chad Smith has proposed merging ~chad.smith/software-properties:ua-status-from-json-focal into software-properties:ubuntu/focal.

Commit message:
utils: prefer ua status from status.json. Support schema 0.1 format

Adjust gtk.utils.get_ua_status to prefer reading
/var/lib/ubuntu-advantage/status.json instead of invoking
ua status on the commandline due to a network roundtrip that
is performed while running the command.

This status.json file will exist on all machines attached to an
Ubuntu Advantage subscription.

Unattached machines will persist status.json due to a systemd timer
that will sync current unattached or attached status to
/var/lib/ubuntu-advantage/status.json.

Allow get_ua_status will now also check a _schema_version key from
ua status which will log if the schema version has changed from the
expected version "0.1".

Changes in schema version may imply incompatibility with reading
UA status.

Requested reviews:
  Lucas Albuquerque Medeiros de Moura (lamoura)
  Grant Orndorff (orndorffgrant)
  Robert Ancell (robert-ancell)

For more details, see:
https://code.launchpad.net/~chad.smith/software-properties/+git/software-properties/+merge/411049
-- 
Your team Ubuntu Core Development Team is subscribed to branch software-properties:ubuntu/focal.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 5693 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20211029/c58cd606/attachment.diff>


More information about the Ubuntu-reviews mailing list