[Merge] ~mirespace/ubuntu/+source/corosync:sru-corosync-bionic-lp1677684-lp1437359 into ubuntu/+source/corosync:ubuntu/bionic-devel

[Athos Ribeiro]

Hi Miriam,

Thanks for the MP. This is looking good so far! I have two comments inline regarding the version string added to the symbols file, the changelog entry, and the commit message.

Diff comments:

> diff --git a/debian/changelog b/debian/changelog
> index ec03e27..106c1ba 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,18 @@
> +corosync (2.4.3-0ubuntu1.3) bionic; urgency=medium
> +
> +  [Miriam España Acebal]
> +  * d/libtotem-pg5.symbols: Including postixed version for avoiding
> +  symbols-file-contains-current-version-with-debian-revision
> +  lintian error.

These last two lines should be indented to be aligned with the text on the first line. Moreover, is there a typo in the description (and in the commit message)? Namely, s/postixed/postfixed/ ?

> +
> +  [Jorge Niedbalski]
> +  * d/control: corosync binary depends on libqb-dev (LP: #1677684)
> +
> +  [Rafael David Tinoco]
> +  * debian/corosync-notifyd.init: fix for 2 PIDFILEs declared (LP: #1437359)
> +
> + -- Miriam España Acebal <miriam.espana at canonical.com>  Tue, 28 Sep 2021 20:00:07 +0200
> +
>  corosync (2.4.3-0ubuntu1.2) bionic; urgency=medium
>  
>    * d/p/lp1911904-Don-t-lock-all-current-and-future-memory-if-can-t-in.patch:
> diff --git a/debian/libtotem-pg5.symbols b/debian/libtotem-pg5.symbols
> index c9b56eb..d3ecc21 100644
> --- a/debian/libtotem-pg5.symbols
> +++ b/debian/libtotem-pg5.symbols
> @@ -11,6 +11,7 @@ libtotem_pg.so.5 libtotem-pg5 #MINVER#
>   cipher_to_nss at Base 1.99.9
>   crypto_authenticate_and_decrypt at Base 1.99.9
>   crypto_encrypt_and_sign at Base 1.99.9
> + crypto_get_current_sec_header_size at Base 2.4.3-0ubuntu1.3~

As Sergio mentioned here, I suppose the version string we want to add here is "2.4.3-0ubuntu1.1~" since the symbol was added in the 2.4.3-0ubuntu1.1 revision.

>   crypto_init at Base 1.99.9
>   crypto_sec_header_size at Base 1.99.9
>   cypher_block_len at Base 1.99.9


-- 
https://code.launchpad.net/~mirespace/ubuntu/+source/corosync/+git/corosync/+merge/409319
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~mirespace/ubuntu/+source/corosync:sru-corosync-bionic-lp1677684-lp1437359 into ubuntu/+source/corosync:ubuntu/bionic-devel.