[Merge] ~lamoura/update-notifier:fallback-to-lsb-release into update-notifier:master

Lucas Albuquerque Medeiros de Moura lucas.moura at canonical.com
Wed May 26 17:23:21 UTC 2021


Lucas Albuquerque Medeiros de Moura has proposed merging ~lamoura/update-notifier:fallback-to-lsb-release into update-notifier:master.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~lamoura/update-notifier/+git/update-notifier/+merge/403341

Currently, we try to get the distro name and version directly from the /etc/os-release file. However, some distros seems to not ship that file on them. You can see an example of this happening in this bug:

https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1898928

Even though this bug is not related to update-notifier, it can potentially affect it too.

Because of that, we are now updating the logic on apt-check to fallback to calling lsb_release if we don't have the /etc/os-release file. This allows apt-check to keep working on those distros
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~lamoura/update-notifier:fallback-to-lsb-release into update-notifier:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 6511 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20210526/cf7c39c6/attachment.diff>


More information about the Ubuntu-reviews mailing list