[Merge] ~ubuntu-core-dev/ubuntu/+source/systemd:lp1664844-focal into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal

Ɓukasz Zemczak lukasz.zemczak at canonical.com
Tue May 25 09:00:22 UTC 2021


Hey Dan, thanks for the review! I'll look into if that commit is needed (in more detail) today, but  why do you think it's required? I don't know all the context of the commit in question, but looking at the actual commit [1] this at least seems to be unrelated to setting the activation policy? I mean, all the code paths, at least with my first glance-check, should be accessible and none of the changes there should be required for things to work. Sure, without this commit I suppose the issue of setting the mac address for interfaces that are already up will still be there, but this feels like a separate issue that maybe should be cherry-picked separately, with a separate SRU bug?

I'm sure I tested at least the always-up, always-down and manual cases for focal, which should be affected by the lack of this commit - and it worked as expected. I'll re-do my tests today.

Am I missing something?
-- 
https://code.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/+git/systemd/+merge/402644
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal.



More information about the Ubuntu-reviews mailing list