[Merge] ~robert-ancell/software-properties:esm into software-properties:ubuntu/master

Chad Smith chad.smith at canonical.com
Wed Jun 9 03:05:00 UTC 2021


Review: Approve

+1 from me, tested on bionic with the minor change from what you'll release to Focal and later. 

--- utils.py.1	2021-06-08 20:57:20.000000000 -0600
+++ utils.py	2021-06-08 20:58:28.236295399 -0600
@@ -82,7 +82,7 @@
     # access contracts.canonical.com/v1/resources.
     try:
         # Success writes UA_STATUS_JSON
-        result = subprocess.run(['ua', 'status', '--format=json'], capture_output=True)
+        result = subprocess.run(['ua', 'status', '--format=json'], stdout=subprocess.PIPE)
     except Exception as e:
         print("Failed to call ubuntu advantage client:\n%s" % e)
         return {}

-- 
https://code.launchpad.net/~robert-ancell/software-properties/+git/software-properties/+merge/400153
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~robert-ancell/software-properties:esm into software-properties:ubuntu/master.



More information about the Ubuntu-reviews mailing list