[Merge] ~xnox/ubuntu-dev-tools:fix-pull-pkg into ubuntu-dev-tools:master

Mattia Rizzolo mattia at mapreri.org
Tue Jan 19 00:11:09 UTC 2021



Diff comments:

> diff --git a/ubuntutools/pullpkg.py b/ubuntutools/pullpkg.py
> index 5e2a22b..e2411bc 100644
> --- a/ubuntutools/pullpkg.py
> +++ b/ubuntutools/pullpkg.py
> @@ -344,14 +344,14 @@ class PullPkg(object):
>  
>          mirrors = []
>          if options['mirror']:
> -            mirrors.append(options['mirror'])
> +            mirrors.extend(options['mirror'])
>          if pull == PULL_DDEBS:
>              config = UDTConfig(options['no_conf'])
>              ddebs_mirror = config.get_value(distro.upper() + '_DDEBS_MIRROR')
>              if ddebs_mirror:
>                  mirrors.append(ddebs_mirror)
>          if mirrors:
> -            Logger.debug("using mirrors %s", ", ".join(mirrors))
> +            Logger.debug("using mirrors %s" % ", ".join(mirrors))

why this hunk?

the comma should work perfectly there, doesn't it?  it actually makes the string interpolation be deferred to the logging module, so that it happens only if the message will be handled, else it won't happen at all.
I agree that it's a trivial matter, but if there are no reasons to change it… :)

>              params['mirrors'] = mirrors
>  
>          params['verify_signature'] = not options['no_verify_signature']


-- 
https://code.launchpad.net/~xnox/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/396459
Your team Ubuntu Development Team is requested to review the proposed merge of ~xnox/ubuntu-dev-tools:fix-pull-pkg into ubuntu-dev-tools:master.



More information about the Ubuntu-reviews mailing list