[Merge] ~callmepk/ubuntu/+source/wslu:ubuntu/master into ~ubuntu-core-dev/ubuntu/+source/wslu:ubuntu/master
Patrick Wu
patrick.wu at canonical.com
Thu Jan 14 12:58:03 UTC 2021
> Thanks for the work patrick, some comments
>
> - the merge request has some conflicts, maybe a debdiff would be easier than rebasing git?
>
> - sounds like upstream fixed the issue in that commit in a different way?
> https://github.com/wslutilities/wslu/commit/653d67bd
>
> wouldn't it make sense to cherry pick their fix instead?
>
> - changes to upstream code are usually done by adding a patch to debian/patches and not editing directly the source
>
> - the description is not really explaining the issue, the upstream commit one sounds nicer 'Avoid error message when the file doesn't exist'
>
> - if there is a bug that should be closed in the upload please list it in the changelog entry as (lp: #nnn)
>
> I'm happy to fix those nitpicks and upload for you if you prefer but let me know if there is a reason to prefer you variant of the fix to the upstream one
I decided to create a new MR due to the mess created during the process... This should address all of the issue you mentioned
--
https://code.launchpad.net/~callmepk/ubuntu/+source/wslu/+git/wslu/+merge/396311
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/wslu:ubuntu/master.
More information about the Ubuntu-reviews
mailing list