[Merge] ~gjolly/livecd-rootfs:no_rbind_devtmpfs into livecd-rootfs:ubuntu/master

John Chittum john.chittum at canonical.com
Mon Feb 22 15:23:25 UTC 2021


offering a small nit now. I'm not sure of all possible ramifications here. Could you add in a description what testing you've done? that might help me narrow down other things to try to ensure we don't have any issues.

Diff comments:

> diff --git a/live-build/functions b/live-build/functions
> index ffeeeae..8fd1695 100644
> --- a/live-build/functions
> +++ b/live-build/functions
> @@ -131,7 +131,7 @@ setup_mountpoint() {
>          chown root:kmem /dev/mem
>      fi
>  
> -    mount --rbind /dev "$mountpoint/dev"
> +    mount live-dev -t devtmpfs "$mountpoint/dev"

nit -- the others are `proc-live` and `sysfs-live`, so this should be `dev-live`

>      mount proc-live -t proc "$mountpoint/proc"
>      mount sysfs-live -t sysfs "$mountpoint/sys"
>      mount securityfs -t securityfs "$mountpoint/sys/kernel/security"


-- 
https://code.launchpad.net/~gjolly/livecd-rootfs/+git/livecd-rootfs/+merge/398461
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/master.



More information about the Ubuntu-reviews mailing list