[Merge] ~mitya57/compiz:cython-distutils into compiz:master
Dmitry Shachnev
mitya57 at gmail.com
Sun Apr 25 18:26:27 UTC 2021
Dmitry Shachnev has proposed merging ~mitya57/compiz:cython-distutils into compiz:master.
Commit message:
Build the compizconfig Python extension using distutils. Bump required CMake version to 3.17 to make this possible.
Requested reviews:
Artem (artem4)
Compiz Maintainers (compiz-team)
Related bugs:
Bug #1926046 in Compiz: "Python extension module should be installed into arch-dependent directory"
https://bugs.launchpad.net/compiz/+bug/1926046
For more details, see:
https://code.launchpad.net/~mitya57/compiz/+git/compiz/+merge/401753
Prior to this change, compizconfig-python/setup.py was not actually building the extension. It was only generating and installing the egg-info directory. The extension was built and installed manually by code in CMakeLists.txt. However, that code did not use the correct installation directory.
As Artem has found out in bug 1926046, the reason for using custom CMake code is no longer true, as new CMake versions (≥ 3.16) resolve the dependencies correctly. So we may now switch back to using distutils for that. So this partially reverts https://git.launchpad.net/compiz/commit/?id=7554df0452c5a567.
The first commit bumps the CMake version. I chose 3.17 because it provides ${Python3_SOABI} which I wanted to use. The second commit gets rid of deprecated FindPythonInterp/FindPythonLibs in favor of modern FindPython3. The third commit contains the main change.
--
Your team Compiz Maintainers is requested to review the proposed merge of ~mitya57/compiz:cython-distutils into compiz:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 10620 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20210425/fd180682/attachment.diff>
More information about the Ubuntu-reviews
mailing list