[Merge] ~codyshepherd/livecd-rootfs/+git/livecd-rootfs:cpc-ubuntu-server into livecd-rootfs:ubuntu/xenial

[Steve Langasek]

Review: Needs Fixing



Diff comments:

> diff --git a/live-build/ubuntu-cpc/hooks.d/chroot/999-cpc-fixes.chroot b/live-build/ubuntu-cpc/hooks.d/chroot/999-cpc-fixes.chroot
> index 56b6950..b5a8ecd 100755
> --- a/live-build/ubuntu-cpc/hooks.d/chroot/999-cpc-fixes.chroot
> +++ b/live-build/ubuntu-cpc/hooks.d/chroot/999-cpc-fixes.chroot
> @@ -166,6 +166,10 @@ if [ "${SUBPROJECT:-}" = minimized ]; then
>  	_xchroot "${rootd}" apt clean
>  fi
>  
> +# install grub-legacy-ec2 and ubuntu-server for all ubuntu-cpc for LP: #1888575
> +_xchroot "${rootd}" env DEBIAN_FRONTEND=noninteractive \
> +  apt-get -y install --no-install-recommends grub-legacy-ec2 ubuntu-server
> +

Shouldn't ubuntu-server already be installed prior to this, so no need to reinstall?

Also I don't think use of --no-install-recommends is correct here. CPC images use recommends in general; structurally, it's the right thing to do for these packages also.  In practice, grub-legacy-ec2 has no recommends, and ubuntu-server being already installed means its recommends are also already installed, so presently --no-install-recommends should make 0 difference to what's installed; but it's architecturally more correct not to use it.

>  #### END COMMON ARCH FUNCTIONS
>  
>  


-- 
https://code.launchpad.net/~codyshepherd/livecd-rootfs/+git/livecd-rootfs/+merge/390849
Your team Ubuntu Core Development Team is subscribed to branch livecd-rootfs:ubuntu/xenial.