[Merge] ~paelzer/ubuntu-seeds/+git/platform:prepare-to-drop-server-ship into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:groovy

Bryce Harrington bryce at bryceharrington.org
Thu Sep 3 04:54:21 UTC 2020


On Wed, Sep 02, 2020 at 01:56:27PM -0000, Christian Ehrhardt  wrote:
> Bryce: "I have a few suggestions and questions below, hopefully they are useful."
> 
> They are - thanks for the review!
> 
> 
> Bryce: "It looks like even with these changes, there are still items left in
> server-ship?"
> 
> But all bits in server-ship that are left are held in main by other pieces the server team already has. And listing a package multiple times in many places has turned out to be misleading as well.
> There was a full scale analysis of this while you were away and is available (for internal viewers) at:
> https://docs.google.com/spreadsheets/d/1tm7OeFqGhG4Ox7lomOJNAdFvYMeuudgtPkUU65hzTfw

Aha!  That is the analysis I expected.
I didn't have time today to doublecheck that list exhaustively but spot
checking it looks ok and I trust you've attended to everything.

> Done:
> - changed: demoted typo fixed
> - changed: HA spelled out now
> - changed: explained libaio-dev in the commit message
> - Explain: Proxy was formerly for haproxy which is more HA than proxy and therefore moved it
> - changed: I reintroduced Proxy: for squid
> - changed: mentioned the two old LP bugs for squid as a comment in the seed
> - explain: php-recode was already cleaned up in a later commit
> - explain: the rest of the php things in main are pulled in by these or by the packages in the lamp task
> - explain: dovecot-[pop3d|imapd] are already in the mail-server task and not listed again intentionally (duplication)
> - explain: I already added another subcategory later "Log parsing and status gathering" where aide/checksecurity fit well
> - changed: retained the LP: #1700826 info for numactl
> - explain: yes the plan is to also remove "ship" (and the no more used boot and d-i-requirements then)
> - explain: yes I grouped the full ppp stack until we can get rid of it in one place
> - changed: mentioned that libpam-cracklib is already in supported-sysadmin-common
> - changed: "misc" is gone now (and my garage is more organized). "Hardware related" is good for now
> - changed: fixed refrence to community-maas seed
> - changed: fixed impi -> ipmi typo (you didn't ask, but now that I've seen it)
> - explain: radvd is special as it stays with openstack AND us eventually. The first change is the retain only intentionally
> - changed: added an explanation why the openstack move was done with some duplication
> - changed: fixed typo "updateam"

Thanks, that all looks good, +1 now.

Bryce
 
> Thank you so much Bryce.
> 
> Once you have time again you can revisit both MPs and set them to approved if you are ok now.
> I could then land that (on a Monday) and sort out (if any) unexpected promotions/demotions throughout the week.
> -- 
> https://code.launchpad.net/~paelzer/ubuntu-seeds/+git/platform/+merge/389947
> You are reviewing the proposed merge of ~paelzer/ubuntu-seeds/+git/platform:prepare-to-drop-server-ship into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:groovy.

-- 
https://code.launchpad.net/~paelzer/ubuntu-seeds/+git/platform/+merge/389947
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/platform:groovy.



More information about the Ubuntu-reviews mailing list