[Merge] ~paelzer/ubuntu-seeds/+git/ubuntu:prepare-to-drop-server-ship into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:groovy

[Bryce Harrington]

On Tue, Sep 01, 2020 at 06:36:28AM -0000, Christian Ehrhardt  wrote:
> On Mon, Aug 31, 2020 at 11:24 PM Bryce Harrington
> <bryce at bryceharrington.org> wrote:
> 
> > [...]
> > It sounds as if maybe prefork got rolled into apache itself?
> 
> Yes, it was a transitional for a while removed in 2015 (apache2-bin
> was providing the same all the time).
> 
> -Package: apache2-mpm-prefork
> -Architecture: any
> -Section: oldlibs
> -Priority: extra
> -Provides: httpd, httpd-cgi
> -Depends: ${misc:Depends}, apache2 (= ${binary:Version})
> -Description: transitional prefork MPM package for apache2
> - This is a transitional package to apache2 for users of apache2-mpm-prefork and
> - can be safely removed after the installation is complete.
> 
> If you go back in history you'll find that this was very far back.
> You used to install either or the other package to influence the
> worker behavior.
> Today you'd install apache, get a good default and if you want you'd
> a2enmod/dismod either of
> 
> root at g:~# ll /usr/lib/apache2/modules/mod_mpm_*
> -rw-r--r-- 1 root root 67792 Aug 25 12:13
> /usr/lib/apache2/modules/mod_mpm_event.so
> -rw-r--r-- 1 root root 39120 Aug 25 12:13
> /usr/lib/apache2/modules/mod_mpm_prefork.so
> -rw-r--r-- 1 root root 47312 Aug 25 12:13
> /usr/lib/apache2/modules/mod_mpm_worker.so
> 
> 
> The above is FYI for the question on apache2.

Thanks, ok that confirms what I suspected.  So +1 on that change.
 
> On samba-doc and btrfs-tools/progs rename I read your feedback that
> you agreed on my chances - let me know if that is incorrect.

Yep, +1 on those.

> > Regarding the server-ship drop, that really feels like it should be a separate MP, especially given the dependence it has on MP #389947.  I think if you dropped that change from this MP, you could land this MP immediately (apart from my question on the prefork module everything looks good to me.)
> 
> This was required to ensure we are not actually losing something.
> If there is a big benefit of doing the cleanups separately we could
> land them one by one, but the gain by that is almost nothing.
> Which is why I'd like to land them together (see also below about testing)

I understand.  I'm not opposed to the server-ship change, just that it
feels to be a significant change and I'm not even sure what all needs to
be considered in a review so defer on that piece of it.

> > I'd also prefer to see some analysis that dropping server-ship doesn't cause anything to get lost.  I see from MP #389947 that there has been some thought given to that, and looks like this and other MPs are addressing the discrepancies that have come to light, so much of that work is done, it just needs a happy summary that everything is accounted for, and nothing will break with server-ship's removal.  (I know at least this will break my merges board... but that's my own problem to fix, and I should take the opportunity to make its seeds query code more robust...)
> 
> I did that analysis already, you can not test either or the other seed
> change individually in a good way to consider the final result.
> The Ubuntu seed includes the platform seed.
>    STRUCTURE:1:include platform.groovy
> 
> Therefore my analysis was with all that combined:
> - the changes to ubuntu (including to drop server-ship)
> - the changes platform repo taking over seeding of some packages.
> 
> Only "combining both MPs including drop of server-ship" allowed me to
> ensure that nothing is missing eventually by analyzing the effective
> outcome of these combined changes.
> And it also is the reason that this needs to land together.
> 
> 
> I think I have answered the apache question and hopefully made a clear
> case why we'd land them together including the removal of server-ship.
> If you are not ok with it let me know what you think we need to adapt.
> 
> Thanks already for the discussion here !
> Will you also review the platform MP which is a bit bigger?

I can try if no one else can.  I did start to review it but found it
needed a more thorough review than I had time for Monday.  My gut
reaction is it looks like you were thorough and most likely covered
everything needing covered, but doublechecking each piece will take some
time.

> -- 
> https://code.launchpad.net/~paelzer/ubuntu-seeds/+git/ubuntu/+merge/389946
> You are reviewing the proposed merge of ~paelzer/ubuntu-seeds/+git/ubuntu:prepare-to-drop-server-ship into ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:groovy.

-- 
https://code.launchpad.net/~paelzer/ubuntu-seeds/+git/ubuntu/+merge/389946
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu:groovy.