[Merge] ~jchittum/livecd-rootfs:ensure-vmtools-in-vmdk-header into livecd-rootfs:ubuntu/master

[John Chittum]

John Chittum has proposed merging ~jchittum/livecd-rootfs:ensure-vmtools-in-vmdk-header into livecd-rootfs:ubuntu/master.

Commit message:
vmtools version in vmdk header (LP: #1893898)
    
LP: #1893898 describes missing vmtools version from the vmdk headers.
The version should be added as ddb.toolsVersion = "2147483647" however
the sed was no longer replacing a ddb.comment field with the tools
version. Rather than subbing ddb.comment with toolsVersion, this commit
deletes ddb.comment (which the comment mentions could cause errors),
and adds the correct value. There was no visibility into the descriptor
during hook creation, so debug statements were added. This allows us to
quickly verify in the logs that bad statements are removed (the possibly
offending commetns), as well as ensuring that the toolsVersion is added


Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1893898 in open-vm-tools (Ubuntu): "open-vm-tools status is toolsNotInstalled after deploy cloud image groovy-server-cloudimg-amd64.ova"
  https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1893898

For more details, see:
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/392401

Tested by running Ubuntu-Bartender to create a vmdk :

ubuntu-bartender --livecd-rootfs-dir /home/jchittum/dev01/livecd-rootfs/ --build-provider multipass -- --series groovy --project ubuntu-cpc --image-target vmdk

log show the toolsVersion. Checked after as well using dd to extract

dd if=livecd.ubuntu-cpc.vmdk of=descriptor bs=1 skip=512 count=1024

cat descriptor
# Disk Descriptor File
# Created by VMDKstream
version=1
CID=7e5b80a7
parentCID=ffffffff
createType="streamOptimized"

# Extent description
RDONLY 20971520 SPARSE "call-me-stream.vmdk"

#DDB

ddb.adapterType = "lsilogic"
# 20971520 / 63 / 255 rounded up
ddb.geometry.cylinders = "1306"
ddb.geometry.heads = "255"
ddb.geometry.sectors = "63"
ddb.longContentID = "8f15b3d0009d9a3f456ff7b28d324d2a"
ddb.virtualHWVersion = "7"
ddb.toolsVersion = "2147483647"

Tested the VMDK in Virtualbox:

1. made basic cloud-init info
  #cloud-config
  chpasswd:
    list: |
      ubuntu:ubuntu
    expire: False
  ssh_pwauth: True
  ssh_authorized_keys: <SSH_PUB_KEY>
2. used cloud-localds to make an iso
cloud-localds my-seed.iso my-user-data
3. using the Virtualbox GUI, added a new VM, pointing to the VMDK
4. selected new VM : ctrl+s (Setting) : Storage : Controller: IDE : Add Optical Disk : my-seed.iso
5. Booted VM
6. VM boots, able to login with password, able to log in via SSH, system is running (no failed modules), cloud-init finished.

-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jchittum/livecd-rootfs:ensure-vmtools-in-vmdk-header into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3042 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20201016/868e26cf/attachment.diff>