[Merge] ~jchittum/livecd-rootfs:bionic-open-vm-tools-backport into livecd-rootfs:ubuntu/bionic

[John Chittum]

John Chittum has proposed merging ~jchittum/livecd-rootfs:bionic-open-vm-tools-backport into livecd-rootfs:ubuntu/bionic.

Commit message:
Backport vmtools version in vmdk (LP: #1893898)

Backport
LP: #1893898 describes missing vmtools version from the vmdk headers.
The version should be added as ddb.toolsVersion = "2147483647" however
the sed was no longer replacing a ddb.comment field with the tools
version. Rather than subbing ddb.comment with toolsVersion, this commit
deletes ddb.comment (which the comment mentions could cause errors),
and adds the correct value. There was no visibility into the descriptor
during hook creation, so debug statements were added. This allows us to
quickly verify in the logs that bad statements are removed (the possibly
offending comments), as well as ensuring that the toolsVersion is added

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1893898 in open-vm-tools (Ubuntu): "open-vm-tools status is toolsNotInstalled after deploy cloud image groovy-server-cloudimg-amd64.ova"
  https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1893898

For more details, see:
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/394144

Tested with the following:

1. created branch and made updates
2. ran ubuntu-old-fashioned/scripts/ubuntu-bartender build
./ubuntu-bartender --livecd-rootfs-dir /home/jchittum/dev01/livecd-rootfs/ --build-provider multipass -- --series focal --project ubuntu-cpc --image-target vmdk
3. untarred results
4. Using virtualbox, clicked Add
5. Added the produced vmdk file and ensured Virtualbox was able to recognize the vmdk
6. added cloud-init.iso via: Vm->Settings->Storage->Controller:IDE->Add Optical Drive->Choose cloud-init.iso with following cloud-init data: 

#cloud-config
password: passw0rd
chpasswd: { expire: False }
ssh_pwauth: True
ssh_import_id: jchittum

7. attached a serial console to /dev/null via: VM -> Settings -> Serial Ports -> Enable Serial Port -> Port Mode: File -> Path/Address: /dev/null
8. booted instance
9. check uname -a, lsb_release -a, systemctl is-system-running, cloud-init status

Tested the ova following steps 4-9 (except import instead of add)

-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jchittum/livecd-rootfs:bionic-open-vm-tools-backport into livecd-rootfs:ubuntu/bionic.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3216 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20201118/45c3ba59/attachment.diff>