[Merge] ~kondor-dani/compiz:annotate_fix into compiz:master

[Daniel Kondor]

Daniel Kondor has proposed merging ~kondor-dani/compiz:annotate_fix into compiz:master.

Commit message:
Proposed fix for LP #1878545


Requested reviews:
  Compiz Maintainers (compiz-team)
Related bugs:
  Bug #1878545 in Compiz: "annotate plugin draw interface not working (e.g. dbus method call)"
  https://bugs.launchpad.net/compiz/+bug/1878545

For more details, see:
https://code.launchpad.net/~kondor-dani/compiz/+git/compiz/+merge/383948

Cause of bug (in plugins/annotate/src/annotate.cpp):
 -- "tool" variable in AnnoScreen::draw() gets overwritten between lines 305 and 322 (is it undefined behavior to save the c_str() of the value returned by CompOption::getStringOptionNamed()?)
 -- AnnoScreen::draw() needs to call handleEventSetEnabled() and glPaintOutputSetEnabled() to actually draw anything on the screen

Changes:
 -- store tool in a local std::string
 -- add missing calls to ensure result is drawn on the screen

-- 
Your team Compiz Maintainers is requested to review the proposed merge of ~kondor-dani/compiz:annotate_fix into compiz:master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1945 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200514/28d09dcb/attachment.diff>