[Merge] ~lucaskanashiro/ubuntu/+source/openvpn:groovy-merge into ubuntu/+source/openvpn:debian/sid

Christian Ehrhardt  christian.ehrhardt at canonical.com
Thu May 7 05:08:02 UTC 2020


You stopped chaingin commands (good), but did not yet use `set -e`.
In general -e is a goot "catch something unexpected" approach.
Any reason not to do so?

Furthermore not using -x to not be forced to use allow-stderr is good.
To get some traction where in your script execution was when an error occurred I'd recommend converting your good comments that you have above each section like:

from
+# Create the CA directory inside the config directory
+cd $CONFIG_DIR
to
+ echo "# Create the CA directory inside the config directory"
+cd $CONFIG_DIR

That is almost as good as -x for your case and will allow to not `set -x` and use the stderr detection.
-- 
https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/openvpn/+git/openvpn/+merge/383178
Your team Ubuntu Server Developers is requested to review the proposed merge of ~lucaskanashiro/ubuntu/+source/openvpn:groovy-merge into ubuntu/+source/openvpn:debian/sid.



More information about the Ubuntu-reviews mailing list