[Merge] ~lukasmaerdian/netplan/+git/ubuntu:slyon/drop-old-integration-fix into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu/master
Ćukasz Zemczak
lukasz.zemczak at canonical.com
Thu Mar 26 12:27:00 UTC 2020
Review: Needs Fixing
Looking good! One small thing (a note for your future distro work!): for debian/changelog entries, those need to be wrapped at 80 characters (if possible). This, of course, applies only to the changelog entries per-se, the rest of the changelog has different rules.
So could you move the 'd/p/0002-Adopt-integration-tests-for-NetworkManager-v1.22-foc.patch' filename to a separate line? Thanks!
--
https://code.launchpad.net/~lukasmaerdian/netplan/+git/ubuntu/+merge/381166
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu/master.
More information about the Ubuntu-reviews
mailing list