[Merge] ~bryce/ubuntu/+source/cacti:cacti-merge-v1.2.10+ds1-1-focal into ubuntu/+source/cacti:debian/sid

[Bryce Harrington]

You have been requested to review the proposed merge of ~bryce/ubuntu/+source/cacti:cacti-merge-v1.2.10+ds1-1-focal into ubuntu/+source/cacti:debian/sid.

For more details, see:
https://code.launchpad.net/~bryce/ubuntu/+source/cacti/+git/cacti/+merge/381078

Cacti is using "foo{i}" type syntax in a few places, that is deprecated in php7.4 and should be "foo[i]" with square brackets rather than curly.

Upstream fixed the same issue in a different file, guess they just missed mib_parser.php.  See https://github.com/Cacti/cacti/commit/eee5ae188708f8c52749a58478d205b51fbaf4f8

I've forwarded the fix upstream at https://github.com/Cacti/cacti/pull/3372

We're one release behind Debian, however it unfortunately doesn't include this fix.  It does contain a CVE fix though, in addition to a couple dozen sensible sounding bug fixes (and no new features), so I've gone ahead and done the merge.

Usual tags pushed.

PPA posted to https://launchpad.net/~bryce/+archive/ubuntu/cacti-merge-v1.2.10+ds1-1



-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~bryce/ubuntu/+source/cacti:cacti-merge-v1.2.10+ds1-1-focal into ubuntu/+source/cacti:debian/sid.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 11135 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200324/716aac7e/attachment-0001.diff>