[Merge] ~xnox/livecd-rootfs:snap-preseed-with-channel into livecd-rootfs:ubuntu/master

[Robert C Jennings]

Review: Needs Information

Hi Dimitri,

I see that this MP makes it unnecessary to specify if a snap is classic.  I like that we wouldn't be writing invalid preseed yaml.  Today we certainly can break pre-seeding should someone specify classic/strict that is out of line with the snap store.  I'd rather we still require the hooks to explicitly call out the expected confinement for the snap.

Getting a snap in the store that has classic confinement is no low bar, but I feel that it's still a separate decision to include a classic snap in an official image and that should be encoded in the hook.  Requiring confinement to be explicit would make it clear to anyone involved with the code (author, reviewer, developer) the intention for the image.  And should the confinement of the snap in the store not match the confinement specified by the caller in livecd-rootfs it should raise a build-time error (rather than the boot-time failure we have today).

Ideally I'd like to see this decided upon and added to the policy document regarding snap pre-seeding.
-- 
https://code.launchpad.net/~xnox/livecd-rootfs/+git/livecd-rootfs/+merge/385064
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~xnox/livecd-rootfs:snap-preseed-with-channel into livecd-rootfs:ubuntu/master.