[Merge] ~brian-murray/ubuntu-release-upgrader:python-dbg-fix into ubuntu-release-upgrader:ubuntu/master

[Brian Murray]

Brian Murray has proposed merging ~brian-murray/ubuntu-release-upgrader:python-dbg-fix into ubuntu-release-upgrader:ubuntu/master.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1887544 in ubuntu-release-upgrader (Ubuntu): "can not upgrade from 18.04 to 20.04"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1887544

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/388513

The fix for bug 1875523 does not resolve failures to calculate upgrades for people who have python-dbg installed on Ubuntu 18.04 LTS. This was discovered when investigating bug 1887544 and a minimal test case can be created by just installing python-pyqt5-dbg and then trying to upgrade to Ubuntu 20.04 LTS. By replacing python-dbg with python2-dbg the upgrade can proceed.

Here's a portion of the an upgrade I did from 18.04 LTS w/ python-pyqt5-dbg installed to Ubuntu 20.04 LTS.

2020-07-31 09:45:21,140 DEBUG quirks: running PreDistUpgradeCache
2020-07-31 09:45:21,140 DEBUG running Quirks.PreDistUpgradeCache
2020-07-31 09:45:21,140 INFO checking for python-dbg
2020-07-31 09:45:21,140 INFO installing python2-dbg because python-dbg was installed
2020-07-31 09:45:21,140 DEBUG Installing 'python2-dbg' (python-dbg was installed on the system)
2020-07-31 09:45:21,282 INFO removing python-dbg because python2-dbg is being installed
2020-07-31 09:45:21,282 DEBUG Removing 'python-dbg' (python2-dbg is being installed on the system)
2020-07-31 09:45:21,282 INFO failed to remove python-dbg
2020-07-31 09:45:21,283 INFO checking for python-minimal
2020-07-31 09:45:21,283 INFO installing python-is-python2 because python-minimal was installed
2020-07-31 09:45:21,283 DEBUG Installing 'python-is-python2' (python-minimal was installed on the system)
2020-07-31 09:45:21,300 INFO removing python-minimal because python-is-python2 is being installed
2020-07-31 09:45:21,300 DEBUG Removing 'python-minimal' (python-is-python2 is being installed on the system)
2020-07-31 09:45:21,300 INFO failed to remove python-minimal

While the log file says the packages failed to remove (which I just noticed) they did end up being removed.

2020-07-31 09:45:26,664 DEBUG Remove: fwupdate-signed gnome-settings-daemon-schemas libapt-inst2.0 libapt-pkg5.0 libcupscgi1 libcupsmime1 libcupsppdc1 libebook-1.2-19 libedata-book-1.2-25 libedata-cal-1.2-28 libfwup1 libldb1 libpolkit-backend-1-0 libpython-dbg libpython-stdlib libsensors4 libsnmp30 python python-dbg python-minimal python-pyqt5 python-pyqt5-dbg python-pyqt5.qtopengl python-pyqt5.qtopengl-dbg python-pyqt5.qtsensors python-pyqt5.qtsensors-dbg python-pyqt5.qtwebchannel uno-libs3

So I think this change is okay but I'd appreciate a second opinion.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~brian-murray/ubuntu-release-upgrader:python-dbg-fix into ubuntu-release-upgrader:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 3361 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200731/77b2c7c9/attachment.diff>