[Merge] ~powersj/livecd-rootfs/+git/livecd-rootfs:fix-unbound-variable into livecd-rootfs:ubuntu/master

Joshua Powers josh.powers at canonical.com
Mon Jul 13 20:09:26 UTC 2020


Joshua Powers has proposed merging ~powersj/livecd-rootfs/+git/livecd-rootfs:fix-unbound-variable into livecd-rootfs:ubuntu/master.

Commit message:
functions: fix unbound variable



Requested reviews:
  Canonical Cloudware (cloudware)
  Ubuntu Core Development Team (ubuntu-core-dev)

For more details, see:
https://code.launchpad.net/~powersj/livecd-rootfs/+git/livecd-rootfs/+merge/387329

With the recent snap preseed changes, the channel variable is not always set. The next few lines even check for this, but the daily Groovy builders are throwing errors due to the unbound variable:

/build/config/functions: line 643: $3: unbound variable

https://i488055617.restricted.launchpadlibrarian.net/488055617/buildlog_ubuntu_groovy_amd64_amd64-ec2_cpc_BUILDING.txt.gz?token=hZ191HmrBxwTkWrV3V97HHPHSPDjmRdJ

https://i488387714.restricted.launchpadlibrarian.net/488387714/buildlog_ubuntu_groovy_amd64_amd64-ec2_cpc_BUILDING.txt.gz?token=JGxVndZwx1Gw9mqxD3r6sLhx8Tp6D0Wh


-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~powersj/livecd-rootfs/+git/livecd-rootfs:fix-unbound-variable into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 518 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200713/8ca95772/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list