[Merge] livecd-rootfs:sil2100/appliance-images into livecd-rootfs:ubuntu/master

Łukasz Zemczak lukasz.zemczak at canonical.com
Wed Jul 8 07:29:33 UTC 2020


Łukasz Zemczak has proposed merging livecd-rootfs:sil2100/appliance-images into livecd-rootfs:ubuntu/master.

Commit message:
Add support for uc18 appliance images.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1863024 in livecd-rootfs (Ubuntu): "SRU: bootable buildd images for all releases"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1863024

For more details, see:
https://code.launchpad.net/~ubuntu-core-dev/livecd-rootfs/+git/livecd-rootfs/+merge/387018

Add support for uc18 appliance images.

This is the simpler solution. Generally the idea is to make adding new appliances as painless as possible. Modifying livecd-rootfs everytime when there is a new appliance image popping up feels wrong, which is why I am looking for ways to make that less painful.

In this solution we're handling a special sub-arch starting with 'appliance-<NAME>', to specify an exact model name to build from.

I was also thinking, that maybe we should allow this as a generic solution for *all* core images, as basically for ubuntu-core there is nothing like SUBARCH, only the model name matters. That solution is here, but it's a bit more invasive and controversial:
https://code.launchpad.net/~ubuntu-core-dev/livecd-rootfs/+git/livecd-rootfs/+merge/386307
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of livecd-rootfs:sil2100/appliance-images into livecd-rootfs:ubuntu/master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 93164 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200708/f65f092d/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list