[Merge] ~lucaskanashiro/ubuntu/+source/nut:merge-focal into ubuntu/+source/nut:debian/sid

[Christian Ehrhardt ]

Review: Needs Fixing

Changelog:
- [√] old content and logical tag match as expected
- [√] changelog entry correct version and targeted codename
- [x] changelog entries correct
 => Minor change-log issue to resolve - see inline comment
- [√] update-maintainer has been run

Actual changes:
- [√] no upstream changes to consider
- [√] no further upstream version to consider
- [√] debian changes look safe
      In particular the unsupported py2 drop is good.
      Yes one might complain about a lost feature, but better than having broken code.

Old Delta:
- [√] dropped changes are ok to be dropped
- [-] nothing else to drop
      These days I'm not sure anymore on 2f085675 "d/nut-server.postinst, d/nut-cgi.postinst: 
      ensure nut is member of group dialout". Going back in time (a lot) this was added in 14.04 
      for upgrades from hardy. Debian switched in 0.44.1-3 to need the user to chown serials.
      Maybe we keep it for 20.04 as the last release. But following that new installs (upgraders 
      will still have nut be a dialout member) are very++ unlikely to have classic serials.
      For ipmi/usb based ports (what you'd expect today) udev rules will set things up correctly 
      (/lib/udev/rules.d/62-nut-usbups.rules shipped in nut-server).
      When you do the minor update for the changelog, would you mind putting this into the commit 
      that adds nut to dialout like "Droppable after 20.04 <quote the above>"?
- [√] changes forwarded upstream/debian (if appropriate)
      We discussed the O3 ppc symbols yesterday - thanks for adding the hint
      
New Delta:
- [√] no new patches added

Build/Test:
- [√] build is ok
- [√] sanity checks test fine (thanks for also doing dep8 in advance)

Diff comments:

> diff --git a/debian/changelog b/debian/changelog
> index f999cdd..d5774fe 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,25 @@
> +nut (2.7.4-11ubuntu1) focal; urgency=medium
> +
> +  * Merge with Debian unstable. Remaining changes:
> +    - remove Build-Depends on libpowerman0-dev
> +    - remove nut-powerman-pdu
> +      + debian/control: remove nut-powerman-pdu package
> +      + debian/nut-powerman-pdu.{install,manpages}: dropped for now
> +    - d/nut-server.postinst, d/nut-cgi.postinst: ensure nut is member of group dialout

This line is too wide

> +    - d/libnutclient0.symbols: Mark more symbols as optional (ppc64el, -O3).
> +      The build flag -O3 is not used by Debian.
> +  * Dropped:
> +    - debian/source_nut.py, debian/{nut,nut-server,nut-client}.install,
> +      debian/rules: Install apport hooks for all top-level nut packages.
> +      [Applied in 2.7.4-10]
> +    - debian/tests/test-nut.py: in the CVE_2012_2944 test, give nut at most
> +      + 5 seconds to shut down, instead of expecting it to be shut down
> +        immediately after sending the killall.
> +      + Additional indication on how to run tests for xenial+
> +      [Applied in 2.7.4-10]
> +
> + -- Lucas Kanashiro <lucas.kanashiro at canonical.com>  Tue, 07 Jan 2020 11:06:43 -0300
> +
>  nut (2.7.4-11) unstable; urgency=medium
>  
>    * Remove python(2) binding and disable nut-monitor package for now as it


-- 
https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/nut/+git/nut/+merge/377255
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~lucaskanashiro/ubuntu/+source/nut:merge-focal into ubuntu/+source/nut:debian/sid.