[Merge] lp:~tdaitx/ubuntu/focal/apport/lp-1851806-fix into lp:~ubuntu-core-dev/ubuntu/focal/apport/ubuntu

[Tiago Stürmer Daitx]

Tiago Stürmer Daitx has proposed merging lp:~tdaitx/ubuntu/focal/apport/lp-1851806-fix into lp:~ubuntu-core-dev/ubuntu/focal/apport/ubuntu.

Requested reviews:
  Apport retracing service (apport)

For more details, see:
https://code.launchpad.net/~tdaitx/ubuntu/focal/apport/lp-1851806-fix/+merge/377182

Python 2 does not support the new security features included 2.20.11-0ubuntu10, mainly O_PATH and dir_fd. Thus for Python 2 most of the changes have been reverted and it will behave as before with one exception: we no longer save the /proc/pid/maps under Python 2 since it is impossible to securely read that file (see bug 1839795 and bug 1839413 for more information).

Some common code was moved into functions to read files and paths from /proc so the Python 2/3 logic for reading those can be better isolated.

The patch includes a small fix for the changes in 2.20.11-0ubuntu13 which introduced a new legacy argument to the command line, which caused the sock container call to fail as it was passing more arguments than needed.
-- 
Your team Ubuntu Core Development Team is subscribed to branch lp:~ubuntu-core-dev/ubuntu/focal/apport/ubuntu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 11973 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200106/28dc02e9/attachment.diff>