[Merge] ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/core_snap_scope-bionic into livecd-rootfs:ubuntu/bionic

Robert C Jennings robert.jennings at canonical.com
Fri Feb 28 16:58:31 UTC 2020


Robert C Jennings has proposed merging ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/core_snap_scope-bionic into livecd-rootfs:ubuntu/bionic.

Commit message:
Fix core_snap variable scope issue

The prior change to pre-seed the correct base added a case to handle
installation of the core snap.  When that was added it created a case
where the $core_snap variable would not be defined when we reach the
end of the _snap_preseed function and evaluate if $core_snap is defined
by empty.  Previous if the snap to preseed was core or core18 then
$core_snap would be "" so this patch addresses that by ensuring the
variable exists and is empty by default.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1864252 in livecd-rootfs (Ubuntu): "preseeded snap installs fail in images"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1864252

For more details, see:
https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/380036
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rcj/livecd-rootfs/+git/livecd-rootfs:bugfix/core_snap_scope-bionic into livecd-rootfs:ubuntu/bionic.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1122 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200228/50508add/attachment.diff>


More information about the Ubuntu-reviews mailing list