[Merge] ~rcj/livecd-rootfs/+git/livecd-rootfs:feature/snap_cohort_key-xenial into livecd-rootfs:ubuntu/xenial

[Robert C Jennings]

Robert C Jennings has proposed merging ~rcj/livecd-rootfs/+git/livecd-rootfs:feature/snap_cohort_key-xenial into livecd-rootfs:ubuntu/xenial.

Commit message:
Use a snap cohort key for consistent parallel builds

The snap-tool code in bionic was never SRU'd to Xenial as the API
interface was removed before it could be used.  Newer releases are
now dropping snap-tool and switching back to using the snap CLI
(LP: #1864252).  This patch updates Xenial to call snap download in
the same way other releases do; passing the snap cohort key argument.
This gives us consistent parallel builds with respect to pre-seeded
snap content and provides parity across releases in livecd-rootfs.

Requested reviews:
  Philip Roche (philroche)
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1864252 in livecd-rootfs (Ubuntu): "preseeded snap installs fail in images"
  https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1864252

For more details, see:
https://code.launchpad.net/~rcj/livecd-rootfs/+git/livecd-rootfs/+merge/379689
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~rcj/livecd-rootfs/+git/livecd-rootfs:feature/snap_cohort_key-xenial into livecd-rootfs:ubuntu/xenial.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1333 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20200224/a80f2267/attachment.diff>