[Merge] ~bryce/ubuntu/+source/php-parser:merge-v4.10.3-1-hirsute into ubuntu/+source/php-parser:ubuntu/devel

[Sergio Durigan Junior]

Review: Needs Fixing

* Changelog:
  - [-] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [-] patches match what was proposed upstream
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [X] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

I've successfully installed/purged the package in a pristine hirsute container.

However, I ran the dep8 tests manually here and noticed they're failing:

autopkgtest [16:58:51]: test command1: -----------------------]                                                                                                                               
autopkgtest [16:58:52]: test command1:  - - - - - - - - - - results - - - - - - - - - -                                                                                                       
command1             FAIL non-zero exit status 2                                                                                                                                              
autopkgtest [16:58:52]: @@@@@@@@@@@@@@@@@@@@ summary                                                                                                                                          
command1             FAIL non-zero exit status 2                                                                                                                                              

The log is too big to post here, but I'm seeing 21 failures in the test.

I also noticed that you created two extra commits on top of the branch in order to refresh the patches.  Maybe it'd be better to squash them into their original commits?  I'm not entirely sure this will make any difference next time the package is merged, but it's something I always try to do.
-- 
https://code.launchpad.net/~bryce/ubuntu/+source/php-parser/+git/php-parser/+merge/395546
Your team Ubuntu Server Developers is requested to review the proposed merge of ~bryce/ubuntu/+source/php-parser:merge-v4.10.3-1-hirsute into ubuntu/+source/php-parser:ubuntu/devel.