[Merge] ~jchittum/livecd-rootfs:vagrant_slow_boot_workaround_with_null_file into livecd-rootfs:ubuntu/master

[Robert C Jennings]

Review: Needs Fixing

Just need a fixup on the kernel cmdline arg in the comment

Diff comments:

> diff --git a/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary b/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> index f9b21d3..b236ea9 100755
> --- a/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> +++ b/live-build/ubuntu-cpc/hooks.d/base/vagrant.binary
> @@ -154,8 +154,16 @@ Vagrant.configure("2") do |config|
>  
>    config.vm.provider "virtualbox" do |vb|
>       vb.customize [ "modifyvm", :id, "--uart1", "0x3F8", "4" ]
> -# Creating a console log file is not an expected behavior for vagrant boxes. LP #1777827
> -#     vb.customize [ "modifyvm", :id, "--uartmode1", "file", File.join(Dir.pwd, "${prefix}-console.log") ]
> +    # Create a NULL serial port to skip console logging by default
> +      vb.customize [ "modifyvm", :id, "--uartmode1", "file", File::NULL ]
> +    # If console logging is desired, uncomment this line and remove prior
> +    # vb.customize [ "modifyvm", :id, "--uartmode1", "file", File.join(Dir.pwd, "${prefix}-console.log") ]
> +    # Ubuntu cloud images, by default, enable tty=ss0. This enables serial consoles to

Shouldn't "tty=ss0" be "console=ttyS0"?

> +    # connect to the images. With the change related to LP #1777827, removing a serial
> +    # file logger, Vagrant image boot times increased and now run greater than 5 minutes
> +    # Creating a console log file is not an expected defaul behavior for vagrant boxes. LP #1777827

Probably don't need lp 1777827 in here twice.

> +    # As a workaround, we create a console connection to File:NULL. LP #1874453
> +    # This is overwriteable in user files to write to a local file
>    end
>  end
>  EOF


-- 
https://code.launchpad.net/~jchittum/livecd-rootfs/+git/livecd-rootfs/+merge/389918
Your team Ubuntu Core Development Team is requested to review the proposed merge of ~jchittum/livecd-rootfs:vagrant_slow_boot_workaround_with_null_file into livecd-rootfs:ubuntu/master.